test(e2e): remove exec.Command calls #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnencia
previously approved these changes
Nov 14, 2024
Switch from using exec.Command to using kind and docker as libraries, so tests won't depend on external binaries. Signed-off-by: Francesco Canovai <[email protected]>
Signed-off-by: Francesco Canovai <[email protected]>
mnencia
force-pushed
the
dev/removeexecs
branch
from
ff3bc26 to
ba9920e
Compare
mnencia
approved these changes
Nov 14, 2024
armru
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling external kind and docker commands, use the kind packages and the docker sdk instead.